With the low tech qualities of ff7 i think he may have wore briefs.
But in FF7AC the times had changed and things had become allot more modern , he may have made the switch to a more relaxed pair of boxers.
I suppose it all depends on the kind of support he favors. Relaxed with freedom or...